Added warning for full reindex and :queue mode - closes #1658

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 5.4.0 (unreleased)
+
+- Added warning for full reindex and `:queue` mode
+
 ## 5.3.1 (2023-11-28)
 
 - Fixed error with misspellings below and failed queries

lib/searchkick/index.rb

@@ -352,6 +352,8 @@ def reindex_records(object, mode: nil, refresh: false, **options)
     # http://www.elasticsearch.org/blog/changing-mapping-with-zero-downtime/
     def full_reindex(relation, import: true, resume: false, retain: false, mode: nil, refresh_interval: nil, scope: nil, wait: nil)
       raise ArgumentError, "wait only available in :async mode" if !wait.nil? && mode != :async
+      # TODO raise ArgumentError in Searchkick 6
+      Searchkick.warn("Full reindex does not support :queue mode - use :async mode instead") if mode == :queue
 
       if resume
         index_name = all_indices.sort.last

test/reindex_test.rb

@@ -159,6 +159,24 @@ def test_relation_queue
     assert_search "product", ["Product A", "Product B"]
   end
 
+  def test_relation_queue_all
+    reindex_queue = Product.searchkick_index.reindex_queue
+    reindex_queue.clear
+
+    store_names ["Product A"]
+    store_names ["Product B", "Product C"], reindex: false
+
+    Product.all.reindex(mode: :queue)
+    Product.searchkick_index.refresh
+    assert_search "product", ["Product A"]
+
+    perform_enqueued_jobs do
+      Searchkick::ProcessQueueJob.perform_now(class_name: "Product")
+    end
+    Product.searchkick_index.refresh
+    assert_search "product", ["Product A", "Product B", "Product C"]
+  end
+
   def test_relation_queue_routing
     reindex_queue = Store.searchkick_index.reindex_queue
     reindex_queue.clear
@@ -243,6 +261,12 @@ def test_full_async_non_integer_pk
     Sku.destroy_all
   end
 
+  def test_full_queue
+    assert_warns "Full reindex does not support :queue mode - use :async mode instead" do
+      Product.reindex(mode: :queue)
+    end
+  end
+
   def test_full_refresh_interval
     reindex = Product.reindex(refresh_interval: "30s", mode: :async, import: false)
     index = Searchkick::Index.new(reindex[:index_name])