Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_instance add the possibility to upgrade/downgrade instance type on the fly #2298

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Sep 18, 2024

SUMMARY

Closes #469

Add the possibiliy to upgrade/downgrade instance type on existing ec2 instances.
The module will stop the instance, modify the instance and then ensure the instance is in the expected state set in state argument.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

Copy link

github-actions bot commented Sep 18, 2024

Docs Build 📝

Thank you for contribution!✨

The docsite for this PR is available for download as an artifact from this run:
https://github.com/ansible-collections/amazon.aws/actions/runs/10942262547

You can compare to the docs for the main branch here:
https://ansible-collections.github.io/amazon.aws/branch/main

File changes:

  • M collections/amazon/aws/ec2_instance_module.html
Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_instance_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_instance_module.html
index 9915fee..7a00d7a 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_instance_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_instance_module.html
@@ -502,8 +502,8 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-ec2-inst
 <a class="ansibleOptionLink" href="#parameter-instance_type" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">string</span></p>
 </div></td>
 <td><div class="ansible-option-cell"><p>Instance type to use for the instance, see <a class="reference external" href="https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html">https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html</a>.</p>
-<p>Only required when instance is not already present.</p>
 <p>At least one of <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-instance-type"><span class="std std-ref"><span class="pre">instance_type</span></span></a></strong></code> or <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-launch-template"><span class="std std-ref"><span class="pre">launch_template</span></span></a></strong></code> must be specificed when launching an instance.</p>
+<p>When the instance is present and the <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-instance-type"><span class="std std-ref"><span class="pre">instance_type</span></span></a></strong></code> specified value is different from the current value, the instance will be stopped and the instance type will be updated.</p>
 </div></td>
 </tr>
 <tr class="row-even"><td><div class="ansible-option-cell">

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e560dc32636b474287824f832d7b1ec3

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 10m 53s
✔️ ansible-test-splitter SUCCESS in 4m 28s
integration-amazon.aws-1 FAILURE in 12m 01s
✔️ integration-amazon.aws-2 SUCCESS in 9m 17s
✔️ integration-amazon.aws-3 SUCCESS in 9m 09s
✔️ integration-amazon.aws-4 SUCCESS in 7m 35s
✔️ integration-amazon.aws-5 SUCCESS in 8m 05s
✔️ integration-amazon.aws-6 SUCCESS in 6m 38s
✔️ integration-amazon.aws-7 SUCCESS in 7m 13s
✔️ integration-amazon.aws-8 SUCCESS in 7m 15s
✔️ integration-amazon.aws-9 SUCCESS in 9m 21s
✔️ integration-amazon.aws-10 SUCCESS in 7m 57s
✔️ integration-amazon.aws-11 SUCCESS in 7m 35s
✔️ integration-amazon.aws-12 SUCCESS in 11m 33s
✔️ integration-amazon.aws-13 SUCCESS in 12m 01s
✔️ integration-amazon.aws-14 SUCCESS in 10m 16s
✔️ integration-amazon.aws-15 SUCCESS in 7m 52s
✔️ integration-amazon.aws-16 SUCCESS in 7m 29s
✔️ integration-amazon.aws-17 SUCCESS in 11m 37s
✔️ integration-amazon.aws-18 SUCCESS in 6m 21s
✔️ integration-amazon.aws-19 SUCCESS in 8m 30s
✔️ integration-amazon.aws-20 SUCCESS in 8m 59s
✔️ integration-amazon.aws-21 SUCCESS in 13m 31s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/945a2d71537a41b3af8418f933442602

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 10m 40s
✔️ ansible-test-splitter SUCCESS in 5m 11s
integration-amazon.aws-1 FAILURE in 22m 08s
✔️ integration-amazon.aws-2 SUCCESS in 17m 40s
✔️ integration-amazon.aws-3 SUCCESS in 10m 11s
✔️ integration-amazon.aws-4 SUCCESS in 9m 53s
✔️ integration-amazon.aws-5 SUCCESS in 6m 27s
✔️ integration-amazon.aws-6 SUCCESS in 8m 21s
✔️ integration-amazon.aws-7 SUCCESS in 7m 25s
✔️ integration-amazon.aws-8 SUCCESS in 7m 39s
✔️ integration-amazon.aws-9 SUCCESS in 8m 42s
✔️ integration-amazon.aws-10 SUCCESS in 10m 09s
✔️ integration-amazon.aws-11 SUCCESS in 5m 42s
✔️ integration-amazon.aws-12 SUCCESS in 12m 35s
✔️ integration-amazon.aws-13 SUCCESS in 12m 40s
✔️ integration-amazon.aws-14 SUCCESS in 8m 22s
✔️ integration-amazon.aws-15 SUCCESS in 8m 48s
✔️ integration-amazon.aws-16 SUCCESS in 6m 25s
✔️ integration-amazon.aws-17 SUCCESS in 8m 33s
✔️ integration-amazon.aws-18 SUCCESS in 8m 47s
✔️ integration-amazon.aws-19 SUCCESS in 6m 36s
✔️ integration-amazon.aws-20 SUCCESS in 9m 06s
✔️ integration-amazon.aws-21 SUCCESS in 18m 17s
Skipped 23 jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2_instance - Upgrade / downgrade ec2 type on the fly
1 participant