Update azure_rm_cdnprofile to include the Standard and Premium Frontdoor options #1588
Conversation
|
Was not sure if you wanted all of the commits for each module done separately or not...assumed separate, though there are some cross dependencies with the tests, so they should be progressively accepted and then tested..tried getting feedback via email, but no engagement. Hope this is an acceptable approach. Thanks! |
| @@ -129,7 +131,7 @@ def __init__(self): | |||
| ), | |||
| sku=dict( | |||
| type='str', | |||
| choices=['standard_verizon', 'premium_verizon', 'custom_verizon', 'standard_akamai', 'standard_chinacdn', 'standard_microsoft'] | |||
| choices=['standard_verizon', 'premium_verizon', 'custom_verizon', 'standard_akamai', 'standard_chinacdn', 'standard_microsoft', 'standard_azurefrontdoor', 'premium_azurefrontdoor'] | |||
There was a problem hiding this comment.
line too long (196 > 160 characters)
There was a problem hiding this comment.
Appreciate the feedback! Changed. Curious if I missed where these type of requirements/coding standards are located? Happy to conform!
|
@jartoo small change request! Thank you very much! |
Fred-sun
added
question
|
@jartoo small change request! Thank you! |
|
@jartoo Please! |
Co-authored-by: Fred-sun <[email protected]>
Co-authored-by: Fred-sun <[email protected]>
|
Thanks for all your help! I learned very much with these pull requests. |
|
I updated the cdn library to be 13.1.1 due to this issue, which affects the ability to manage Azure Front Doors (standard and premium) Azure/azure-sdk-for-python#35801 Otherwise you cannot clear the cache_configuration in Route() and Rule(). |
Fred-sun
added
ready_for_review
Fred-sun
added
high_priority
SUMMARY
Adds the ability to use the existing azure_rm_cdnprofile module to create both a Standard_AzureFrontDoor and Premium_AzureFrontDoor.
Begins to work on #1041 which will require additional pull requests and new modules. This does not complete this issue, however. This also bumps the azure-mgmt-cdn version from 11.0.0 to 13.1.0, which is the latest and will be needed for upcoming pull requests to finish the Front Door (Standard and Premium) functionality.
ISSUE TYPE
COMPONENT NAME
Module: azure_rm_cdnprofile
Change: allows additional SKU options.
ADDITIONAL INFORMATION