-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure_rm_sqlmanagedinstance
- Add support for Managed User Identities to sqlManagedInstance
#1633
azure_rm_sqlmanagedinstance
- Add support for Managed User Identities to sqlManagedInstance
#1633
Conversation
Ping - Can you look at this? I am not able to run the pipelines at dev.azure.com anymore. Every time I go to the web page it signs me out of my account. |
Clear the browser cache and login in again? Due to recent security enhancements, your login session may expire soon. |
I just had to reload the page after logging in. https://dev.azure.com/azclitools/public/_build/results?buildId=184753&view=results |
186ae36
to
d699f34
Compare
ok - it took a while to understand why my test cases were failing. But once I added a task to wait for the sqlmanaged instance to be ready everything works as expected. https://dev.azure.com/azclitools/public/_build/results?buildId=185079&view=results Please review now. Thanks |
@p3ck Yes, some resources created need to wait for the status to change back to 'succesed'. Thanks! |
@p3ck Recently, we will release a new version. But this is a minor version change that will not include this PR. In the near future we will have a breaking change, we will merge this PR. Thank you! |
d699f34
to
0c8057f
Compare
rebased on latest dev - please review. |
azure_rm_sqlmanagedinstance
- Add support for Managed User Identities to sqlManagedInstance
SUMMARY
Adds support for managing User Assigned identities in sqlmanaged instances
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/azure_rm_common_ext.py
plugins/modules/azure_rm_sqlmanagedinstance.py
tests/integration/targets/azure_rm_sqlmanagedinstance/tasks/main.yml
ADDITIONAL INFORMATION
I''m having difficulty testing this. I also tried to pass in user_assigned_identities before I made this patch and it only failed for me. So I don't believe this ever worked.
Testing is very painful because it seems to stay in a provisioning state for days.