Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_sqlmanagedinstance - Add support for Managed User Identities to sqlManagedInstance #1633

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

p3ck
Copy link
Collaborator

@p3ck p3ck commented Jul 15, 2024

SUMMARY

Adds support for managing User Assigned identities in sqlmanaged instances

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/azure_rm_common_ext.py
plugins/modules/azure_rm_sqlmanagedinstance.py
tests/integration/targets/azure_rm_sqlmanagedinstance/tasks/main.yml

ADDITIONAL INFORMATION

I''m having difficulty testing this. I also tried to pass in user_assigned_identities before I made this patch and it only failed for me. So I don't believe this ever worked.

Testing is very painful because it seems to stay in a provisioning state for days.

@p3ck p3ck requested a review from Fred-sun July 15, 2024 18:01
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority new_feature New feature requirments labels Jul 24, 2024
@p3ck
Copy link
Collaborator Author

p3ck commented Aug 26, 2024

Ping - Can you look at this? I am not able to run the pipelines at dev.azure.com anymore. Every time I go to the web page it signs me out of my account.

@xuzhang3
Copy link
Collaborator

Ping - Can you look at this? I am not able to run the pipelines at dev.azure.com anymore. Every time I go to the web page it signs me out of my account.

Clear the browser cache and login in again? Due to recent security enhancements, your login session may expire soon.

@p3ck
Copy link
Collaborator Author

p3ck commented Aug 27, 2024

Ping - Can you look at this? I am not able to run the pipelines at dev.azure.com anymore. Every time I go to the web page it signs me out of my account.

Clear the browser cache and login in again? Due to recent security enhancements, your login session may expire soon.

I just had to reload the page after logging in.

https://dev.azure.com/azclitools/public/_build/results?buildId=184753&view=results

@p3ck p3ck force-pushed the identity-sqlmanagedserver branch 11 times, most recently from 186ae36 to d699f34 Compare August 28, 2024 16:06
@p3ck
Copy link
Collaborator Author

p3ck commented Aug 28, 2024

ok - it took a while to understand why my test cases were failing. But once I added a task to wait for the sqlmanaged instance to be ready everything works as expected.

https://dev.azure.com/azclitools/public/_build/results?buildId=185079&view=results

Please review now.

Thanks

@Fred-sun
Copy link
Collaborator

@p3ck Yes, some resources created need to wait for the status to change back to 'succesed'. Thanks!

@Fred-sun
Copy link
Collaborator

@p3ck Recently, we will release a new version. But this is a minor version change that will not include this PR. In the near future we will have a breaking change, we will merge this PR. Thank you!

@p3ck
Copy link
Collaborator Author

p3ck commented Sep 3, 2024

rebased on latest dev - please review.

@xuzhang3 xuzhang3 changed the title Add support for Managed User Identities to sqlManagedInstance azure_rm_sqlmanagedinstance - Add support for Managed User Identities to sqlManagedInstance Sep 20, 2024
@xuzhang3 xuzhang3 merged commit 9a43760 into ansible-collections:dev Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants