Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA-1842: VM Image SKUs support in Ansible collection for Azure module creation #1719

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Yaish25491
Copy link
Contributor

SUMMARY

Creating azure_rm_imagesku_info module to get all of the available SKU options for VM image.
Creating azure_test_image_skus to test the creation of a VM with an image from the SKU list of options
Updating the test list in the inventory file with azure_test_imageskus test.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_imagesku_info.py
azure_test_image_skus.yml
azure_rm_virtualmachine/inventory.yml

@Fred-sun
Copy link
Collaborator

@Yaish25491 Please fix the below error! Thanks!
ERROR: Found 8 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/azure_rm_imagesku_info.py:30:161: E501: line too long (177 > 160 characters)
ERROR: plugins/modules/azure_rm_imagesku_info.py:34:161: E501: line too long (199 > 160 characters)
ERROR: plugins/modules/azure_rm_imagesku_info.py:77:161: E501: line too long (192 > 160 characters)
ERROR: plugins/modules/azure_rm_imagesku_info.py:168:48: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:169:48: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:177:73: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:178:73: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_imagesku_info.py:184:1: W293: blank line contains whitespace

@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Sep 18, 2024
@Yaish25491
Copy link
Contributor Author

Hi Fred-Sun,
All errors corrected and pushed again for review

@Fred-sun
Copy link
Collaborator

@Yaish25491

ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.argument_spec.properties.automaticOSUpgradeProperties: extra keys not allowed @ data['argument_spec']['properties']['automaticOSUpgradeProperties']. Got {'type': 'bool', 'default': 'false'}
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: nonexistent-parameter-documented: Argument 'publisher' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'id' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'properties' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'publisher_name' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: parameter-type-not-in-doc: Argument 'tags' in argument_spec defines type as 'str' but documentation doesn't define type
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'id' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'name' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'properties' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'publisher_name' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:0:0: undocumented-parameter: Argument 'tags' is listed in the argument_spec, but not documented in the module documentation
ERROR: plugins/modules/azure_rm_imagesku_info.py:30:99: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_imagesku_info.py:35:133: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_imagesku_info.py:200:1: E302: expected 2 blank lines, found 1

Creaing azure_rm_imagesku_info module to get oll of the availble SKU options for VM image.
Creating azure_test_image_skus to test the creation of a vm with an image from the SKU list of options
Updating the test list in the inventory file with azure_test_imageskus test.

Signed-off-by: hyaish <[email protected]>
@Yaish25491
Copy link
Contributor Author

issues fixed and merged

resource_group: "{{ resource_group }}"
name: "{{ vm_name }}"
admin_username: "testuser"
ssh_password_enabled: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the open ports, Now , The default 22 port was disallowed by policy!

Suggested change
ssh_password_enabled: false
ssh_password_enabled: false
open_ports:
- 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority question Further information is requested work in In trying to solve, or in working with contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants