[FEEL FREE TO FINISH] New module: proxysql_cluster

[akimrx]

SUMMARY

IF ANYONE WANTS TO FINISH IT BECAUSE OF #26 (comment), FEEL FREE TO DO IT!

Added new module proxysql_cluster, which implements server management in the ProxySQL cluster.
Read more here.

ISSUE TYPE

• New Module Pull Request

COMPONENT NAME

proxysql_cluster

ADDITIONAL INFORMATION

The linked module proxysql_manage_config has also been updated.

[codecov]

Codecov Report

Attention: Patch coverage is 71.06918% with 46 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (beb3841) to head (6dc9442).
Report is 75 commits behind head on main.

Files	Patch %	Lines
plugins/modules/proxysql_cluster.py	71.06%	34 Missing and 12 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   70.02%   70.12%   +0.10%     
==========================================
  Files           8       10       +2     
  Lines         994     1329     +335     
  Branches      164      220      +56     
==========================================
+ Hits          696      932     +236     
- Misses        222      295      +73     
- Partials       76      102      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Andersson007]

@akimrx thanks for the new module!
Could you please revert renaming of the ignore.txt

[akimrx]

Hi! Yep, a little later

[Andersson007]

@akimrx thanks for the module!

Most the comments from the other PR is relevant here.
When it's ready for review, please put it explicitly and I'll ping the other folks to review.

Thanks.

[Andersson007]

Suggested change

you could also put the seealso section, with a link to related proxysql documentation. E.g. from postgresq_pg_hba module

114 seealso:
115 - name: PostgreSQL pg_hba.conf file reference
116   description: Complete reference of the PostgreSQL pg_hba.conf file documentation.
117   link: https://www.postgresql.org/docs/current/auth-pg-hba-conf.html

Just an idea, not necessary

[Andersson007]

Suggested change

	def update_server_config(self, cursor):
	def update_server_config(self, cursor):

can we pass it only once when initializing the object and use self.cursor everywhere?

[Andersson007]

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module

@markuman if you could take a look, it would be really great

[Andersson007]

Suggested change

	ProxySQL cluster hosts using the B(ProxySQL) admin interface.
	ProxySQL cluster hosts using the B(ProxySQL) admin interface.
	version_added: '1.2.0'

[Andersson007]

FYI: Whoever finishes this, i believe it would be fair if they put themselves in the authors: list

[markuman]

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module

@markuman if you could take a look, it would be really great

I can take over. But I'd like to address #60, #61 and #62 first and release 1.2.0
So this will land in 1.3.0 if no one else will do it before :)

[Andersson007]

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module
@markuman if you could take a look, it would be really great

I can take over. But I'd like to address #60, #61 and #62 first and release 1.2.0
So this will land in 1.3.0 if no one else will do it before :)

sounds very good to me

[markuman]

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module
@markuman if you could take a look, it would be really great

I can take over. But I'd like to address #60, #61 and #62 first and release 1.2.0
So this will land in 1.3.0 if no one else will do it before :)

I will target #19 for the next release.
the benefits of using proxysql in cluster mode are - imo - marginal. Most of the benefits are already targeted by using an orchestration tool like ansible.
If someone has some time to complete this, feel free to adopt this pr.