Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing issue 38 #39

Closed
wants to merge 127 commits into from
Closed

Addressing issue 38 #39

wants to merge 127 commits into from

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Mar 26, 2024

Overall Review of Changes:
Updating controls as per expected results from CIS Benchmark

Issue Fixes:
#38

Enhancements:
None

How has this been tested?:
Tested by running role from this branch on a fresh instance

@mfortin mfortin changed the title Addressiong issue 38 Addressing issue 38 Mar 26, 2024
@MrSteve81
Copy link
Contributor

Please Fix your Sign off for the DCO. I have gone over this PR and It looks great thanks for the finds.

@mfortin
Copy link
Contributor Author

mfortin commented Mar 28, 2024

@MrSteve81 fixed the DCO!

@frederickw082922
Copy link
Contributor

Thank you @mfortin ! Great Catches!

CC: @georgenalen @MrSteve81

@MrSteve81 MrSteve81 self-requested a review April 2, 2024 13:46
MrSteve81
MrSteve81 reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@frederickw082922 frederickw082922 self-requested a review April 2, 2024 14:26
frederickw082922
frederickw082922 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@MrSteve81 MrSteve81 removed the request for review from georgenalen April 2, 2024 14:29
@frederickw082922
Copy link
Contributor

Good day @mfortin ! FYI, your commits are still populating not "Verified". Think options are Re-do your commits with "sign-off-by and verified"? Or I can do a new branch with your updates based on your PR #39?

frederickw082922
frederickw082922 requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all the commits are signed with GPG signatures.

AnvaySingh and others added 17 commits April 16, 2024 12:00
@AnvaySingh @mfortin
Add 18.6.1, 18.6.2, 18.6.3
1376d35 
Included 18.6.1, 18.6.2, 18.6.3 which are recommendations for printer settings.

Signed-off-by: Anvay Singh <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 README and meta file updates
2c17312 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 section 1 updates
2219410 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 section 2 updates
6c9c50d 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 section 5 updates
23eb77a 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 section 9 updates
881aedb 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 section 17 updates
5da967c 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 section 19 updates
7cbdda4 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
v1.0.0 section 18 updates
a559144 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
fixes after testing
fae5e81 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
GH workflow update
4556884 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
updated 1.2.3 variable name
b7c2b65 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
updated ansible vars for testing pipeline
8587003 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
updated unnecessary comments and removed roque score mentions
3c9fb7c 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
removed misc. unneeded items and added the update galaxy workflow
9c6c2da 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
really adding the galaxy update this time
70ae796 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@georgenalen @mfortin
updated checkout version in GH actions
94182b9 
Signed-off-by: George Nalen <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
frederickw082922 and others added 26 commits April 16, 2024 12:00
@frederickw082922 @mfortin
18.7.x Tag fixes
72daa94 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Update cloud_lockout logic
dbd6605 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Update section 19 with loop and change_requires_reboot
8af827e 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Update handeler name to change_requires_reboot
ba60fe8 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Fix 18.9.7.2 title and var
0d06d38 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Fix 18.10.89.2.2 reg value
6dacf01 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Update meta
d2069de 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
defaults main var update
6364571 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
update section5 with handeler name chance
ab04bc3 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
update win_skip_for_test withe latest controls
882419d 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
update changelog
636dbc9 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Update ChangeLog with @mr.Steve81
9d6355d 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Typo Fixes
604be9c 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Only applies to Azure
fb61c71 
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Update control 1.1.6
b26e601 
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Fixing controls stated in issue 38
cae0c88 
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
revert
b6e95b3 
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Update control 1.1.6
c1d533f 
Signed-off-by: Mathieu Fortin <[email protected]>
Signed-off-by: fortinm <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
revert
c3d0d76 
Signed-off-by: fortinm <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Update section18.yml
91373ec 
Signed-off-by: Math Fortin <[email protected]>
Signed-off-by: fortinm <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Fixing controls stated in issue 38
95d211e 
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Addressing issue ansible-lockdown#36
65b9a29 
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
test
2b11c04 
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
test
0c99c0a 
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Fix from ansible-lockdown#32
309f44f 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 @mfortin
Update ChangeLog with fix for ansible-lockdown#32
ddc9819 
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Copy link
Contributor Author

mfortin commented Apr 16, 2024

Looks like I messed that up!

@mfortin mfortin closed this Apr 16, 2024
@mfortin mfortin deleted the issue-38 branch April 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSteve81 MrSteve81 MrSteve81 left review comments

@frederickw082922 frederickw082922 frederickw082922 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfortin @MrSteve81 @frederickw082922 @AnvaySingh @georgenalen