-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backported-* label on stable-* merges #428
Conversation
@himdel does this work with the backports created by patchback? |
Yup, it should just watch the stable-X.Y branch for new pushes, and when something is pushed, it parses the PR number from that. So as long as patchback pushes things there, it should work :) (Or, github, when we merge the PR.) |
b88a19f
to
401d6e5
Compare
runs on push to a stable-* branch, takes the first line of the topmost commit message: Original PR title (#original PR number) (#backport PR number) extracts the first parenthesised PR number, as long as there are 2 and adds a backported-${branch number} label to the original PR
So, this is probably ready... Running with debugging overrides (to assume branch other than master) in https://github.com/ansible/ansible-hub-ui/runs/3042394137, it succeeded in everything apart from actually adding the label (as in both the LABEL and the PR values make sense given the overrides). Both I'm hoping this is because as a PR, it's still running in the context of my repo, and won't have these problems when triggered by a stable push, but it may still fail, we'll see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we just have to merge this and see if it works.
Backport to stable-4.2: 💚 backport PR created✅ Backport PR branch: Backported as #633 🤖 @patchback |
* Add backported-* label on stable-* merges runs on push to a stable-* branch, takes the first line of the topmost commit message: Original PR title (#original PR number) (#backport PR number) extracts the first parenthesised PR number, as long as there are 2 and adds a backported-${branch number} label to the original PR * backported-labels: use actions-ecosystem/action-add-labels@v1 * backported-labels: remove deubgging bits (cherry picked from commit 2b61a8c)
Backport to stable-4.3: 💚 backport PR created✅ Backport PR branch: Backported as #634 🤖 @patchback |
* Add backported-* label on stable-* merges runs on push to a stable-* branch, takes the first line of the topmost commit message: Original PR title (#original PR number) (#backport PR number) extracts the first parenthesised PR number, as long as there are 2 and adds a backported-${branch number} label to the original PR * backported-labels: use actions-ecosystem/action-add-labels@v1 * backported-labels: remove deubgging bits (cherry picked from commit 2b61a8c)
* Add backported-* label on stable-* merges runs on push to a stable-* branch, takes the first line of the topmost commit message: Original PR title (#original PR number) (#backport PR number) extracts the first parenthesised PR number, as long as there are 2 and adds a backported-${branch number} label to the original PR * backported-labels: use actions-ecosystem/action-add-labels@v1 * backported-labels: remove deubgging bits (cherry picked from commit 2b61a8c) Co-authored-by: Martin Hradil <[email protected]>
* Add backported-* label on stable-* merges runs on push to a stable-* branch, takes the first line of the topmost commit message: Original PR title (#original PR number) (#backport PR number) extracts the first parenthesised PR number, as long as there are 2 and adds a backported-${branch number} label to the original PR * backported-labels: use actions-ecosystem/action-add-labels@v1 * backported-labels: remove deubgging bits (cherry picked from commit 2b61a8c) Co-authored-by: Martin Hradil <[email protected]>
Looks like it works :) 4.2 https://github.com/ansible/ansible-hub-ui/runs/3058396169?check_suite_focus=true 👍 (also the labels were actually added here ^ :)) |
…backported-* label to backported PRs (#1025) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue
…backported-* label to backported PRs (#1025) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue (cherry picked from commit 825086d)
…backported-* label to backported PRs (#1025) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue (cherry picked from commit 825086d)
…backported-* label to backported PRs (#1025) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue (cherry picked from commit 825086d)
…backported-* label to backported PRs (#1025) (#1029) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue (cherry picked from commit 825086d) Co-authored-by: Martin Hradil <[email protected]>
…backported-* label to backported PRs (#1025) (#1027) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue (cherry picked from commit 825086d) Co-authored-by: Martin Hradil <[email protected]>
…backported-* label to backported PRs (#1025) (#1028) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue (cherry picked from commit 825086d) Co-authored-by: Martin Hradil <[email protected]>
…backported-* label to backported PRs (ansible#1025) Adding a workflow that updates a backported PR with a backported-* label once merged in a stable-* branch. It's watching for commit messages ending with `foo (ansible#123) (#456)`, and using the penultimate PR number, the format patchback uses. Identical to the UI version ( ansible/ansible-hub-ui#428 ) No-Issue
runs on push to a
stable-\*
branch,takes the first line of the topmost commit message:
extracts the first parenthesised PR number, as long as there are 2
and adds a
backported-${branch number}
label to the original PRCc @ZitaNemeckova , @newswangerd
Also relevant: sanitizers/patchback-github-app#12