Add imported dependencies #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaustein
approved these changes
Jan 23, 2025
art-tapin
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
LGTM! 👍
The changes provide a solid foundation for making the metrics-utility more standalone by properly declaring all dependencies with specific versions. I've tested the branch and can confirm it maintains the same behavior as devel, with the expected warnings that will be addressed in follow-up work.
Special thanks to @himdel for the quick support with troubleshooting the local installation issues.
Ready to merge! 🚀
add dependencies which we import from and are not in python stdlib:
boto3
botocore
distro
insights-analytics-collector
openpyxl
pandas
requests
setuptools
except for pytest, ruff & pre-commit, everything is an existing awx dependency, so start from a known good point of using exactly the same versions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAP-38424 / AAP-39220
Add all packages we import from as dependencies, using the same version that awx currently uses.
This is a step towards being able to run the utility in standalone environment for testing.
Adds:
(Pretty sure most of these can be updated to latest, but starting from a known good state before we have tests.)
Changes:
>4<5to"django==4.2.16"(because awx)"pre-commit>=4.0.1","pytest>=8.3.4","ruff>=0.9.2",This currently does nothing, except install successfully,
but the follow-up PR can focus on dealing with just imports from awx itself.