fix: switch to advisory_lock from DAB instead of pglock #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, fixes a problem introduced by awx removing one of our dependencies 👍 Cc @Ladas While we still depend on the awx environment, this change could break on 2.4 (unless all 2.4 versions are using a recent enough django ansible base). But not doing it breaks on newer 2.5 so... |
dhaustein
force-pushed
the
advisory_lock_from_dab
branch
from
ff3a6b0 to
4a4247b
Compare
|
|
Switching PR to draft. I need to address the fact that in 2.4 there is no DAB. |
|
Closed in favor of #51 It will have the same change we wanted to do here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for errors
Caused by awx removing
django-pglocksand switching to usingadvisory_lockfrom DAB in ansible/awx@f57a986