-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test simple ccsp file #60
Conversation
48df0af
to
e1c8084
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nitpicks otherwise LGTM.
I have one suggestion for the future however. While having the fixtures in conftest.py
is absolutely fine, it does not scale well when the number of fixtures increases.
A trick I picked up in EDA was to create a number of semantically distinct "plugin" files for fixtures and load them in conftest at runtime. https://github.com/ansible/eda-qa/blob/main/conftest.py#L13-L39
But this is not a blocker or even a big deal right now, but might be something to think about for the future. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works :-)
LGTM 👍
e1c8084
to
9a9a382
Compare
|
[AAP-39222]
Description
Similar to the CCSPv2 test where was checked all columns and values from a built CCSPv2 report, the work at hand builds and tests the more simple CCSP one.
Much of the logic is the same with a few key changes:
Prerequisites
Enter the awx virtual env
docker exec -it tools_awx_1 /bin/sh -c " cd awx-dev/metrics-utility && . /var/lib/awx/venv/awx/bin/activate && exec /bin/sh "
Steps to Test
SETUPTOOLS_USE_DISTUTILS=true pytest -s
Expected Results
Both tests should pass
Required Actions
Self-Review Checklist
Code Quality
- If updates are required in the handbook, create a separate PR for the handbook repo.
Notes for Reviewers
Add any additional context or instructions for reviewers here - for example screenshots if needed.