Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-38577] Docs: Add Contributors Guide #62

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

art-tapin
Copy link
Collaborator

@art-tapin art-tapin commented Feb 5, 2025

Description

This PR adds a Contributor’s Guide to metrics-utility, outlining contribution guidelines, the forking workflow, and repository conventions. It ensures clarity for both internal and external contributors.

  • Documents the PR process, including branch workflows and merge criteria.
  • References pre-commit hooks and ruff linter settings from pyproject.toml.
  • Aligns with the developer setup guide (developer_setup.md) for environment setup.
  • Specifies PR approval requirements and merging policies.

Testing

No code changes—documentation only.

Required Actions

Self-Review Checklist

  • Document structure follows open-source best practices.
  • References existing documentation where needed.
  • Ready for review.

Notes:

Related to #61

AAP-38577

@art-tapin art-tapin changed the title [AAP-38577] Add Contributors Guide to metrics-utility [AAP-38577] Docs: Add Contributors Guide Feb 5, 2025
Copy link
Contributor

@ShaiahWren ShaiahWren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, just a few comments/q's

Copy link

@dhaustein dhaustein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but LGTM overall. This probably took some time to write. Good job!

⚠️ One thing I want to mention. Usually a contributor's guide file by convention is named CONTRIBUTING.md or CONTRIBUTING.rst depending on the markup format. See repos for pytest or numpy for example.

docs/contributing/contributor_guide.md Outdated Show resolved Hide resolved
docs/contributing/contributor_guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MilanPospisil MilanPospisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

-- Squashed --

[AAP-38577] Clarify sections 2, 4, 5 & 6 following reviewers suggestions

- Added direct links to pre-commit setup in developer_setup.md.
- Clarified pre-commit enforcement and removed redundant manual checks.
- Explicitly referenced /.pre-commit-config.yaml for configuration details.
- Strengthened guidance on downstream documentation, ensuring internal details remain private.
- Improved wording for code quality and formatting requirements in PR submissions.

[AAP-38577] Improve Contributor Guide: commit messages, branch naming, and dependencies

Ref: [AAP-38577]

[AAP-38577] Add Contributors Guide to metrics-utility

- Introduced a contributor_guide.md under docs/contributing/
- Documents the forking workflow, PR requirements, and code style
- Provides references to developer_setup.md and pyproject.toml
- Aligns with existing repository conventions

Ref: [AAP-38577]
@art-tapin art-tapin force-pushed the docs-contributor_guide branch from 5cd52d5 to 4587379 Compare February 10, 2025 15:04
@art-tapin art-tapin merged commit 16e8bde into ansible:devel Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants