-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAP-38577] Docs: Add Contributors Guide #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, just a few comments/q's
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, but LGTM overall. This probably took some time to write. Good job!
CONTRIBUTING.md
or CONTRIBUTING.rst
depending on the markup format. See repos for pytest or numpy for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
-- Squashed -- [AAP-38577] Clarify sections 2, 4, 5 & 6 following reviewers suggestions - Added direct links to pre-commit setup in developer_setup.md. - Clarified pre-commit enforcement and removed redundant manual checks. - Explicitly referenced /.pre-commit-config.yaml for configuration details. - Strengthened guidance on downstream documentation, ensuring internal details remain private. - Improved wording for code quality and formatting requirements in PR submissions. [AAP-38577] Improve Contributor Guide: commit messages, branch naming, and dependencies Ref: [AAP-38577] [AAP-38577] Add Contributors Guide to metrics-utility - Introduced a contributor_guide.md under docs/contributing/ - Documents the forking workflow, PR requirements, and code style - Provides references to developer_setup.md and pyproject.toml - Aligns with existing repository conventions Ref: [AAP-38577]
5cd52d5
to
4587379
Compare
|
Description
This PR adds a Contributor’s Guide to
metrics-utility
, outlining contribution guidelines, the forking workflow, and repository conventions. It ensures clarity for both internal and external contributors.ruff
linter settings frompyproject.toml
.developer_setup.md
) for environment setup.Testing
No code changes—documentation only.
Required Actions
Self-Review Checklist
Notes:
Related to #61
AAP-38577