Refactor vscode-elements textfield value workaround #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanwigeetika1618
approved these changes
Feb 6, 2025
audgirka
approved these changes
Feb 6, 2025
cidrblock
approved these changes
Feb 6, 2025
shatakshiiii
approved these changes
Feb 6, 2025
|
Making a small change suggested by @abhikdps, then will be ready for merge! |
alisonlhart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes workarounds related to vscode-elements/elements#271, as that was resolved in vscode-elements 1.12.0.
Now the VSCodeTextField
.valueattribute can be accessed and utilized correctly to update the inner element.This PR also resolves a small issue related to this workaround in the Collection and Playbook Project webviews, where when selecting a folder for the init path, the init path would not be updated.
An import for webview-ui-toolkit in the Quick Links webview is also removed in this change, since none of those elements are utilized in that webview.
The collection project webview also now displays the correct init collection path rather than only showing the default path.