Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation list safe area problem #1336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suinkimme
Copy link

@suinkimme suinkimme commented Apr 5, 2024

I had a problem that I couldn't select the navigation list on my iPhone X ~ iPhone 15.

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

I had a problem that I couldn't select the navigation list on my iPhone X ~ iPhone 15.
@suinkimme
Copy link
Author

suinkimme commented Apr 5, 2024

  • Failed to press navigation at the bottom
  • Only SafeAreaView Tag was added and the lint was not checked.

@suinkimme suinkimme changed the title fix navigation list safe area problem fix: navigation list safe area problem Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant