fix: (FormItem) help icon click stopPropagation (#6549)

* fix: (FormItem) help icon click stopPropagation * test: add test case * chore: clean up --------- Co-authored-by: 二货机器人 <[email protected]>
ant-design · Feb 29, 2024 · 8468a08 · 8468a08
1 parent 5ebd04e
commit 8468a08
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/components/form/form-item.tsx b/src/components/form/form-item.tsx
@@ -158,6 +158,7 @@ const FormItemLayout: FC<FormItemLayoutProps> = props => {
           <span
             className={`${classPrefix}-label-help`}
             onClick={e => {
+              e.stopPropagation()
               e.preventDefault()
             }}
           >

diff --git a/src/components/form/tests/form.test.tsx b/src/components/form/tests/form.test.tsx
@@ -330,4 +330,28 @@ describe('Form', () => {
       expect(renderTimes).toEqual(1)
     })
   })
+
+  test('click help not propagate', () => {
+    jest.useFakeTimers()
+    const onClick = jest.fn()
+
+    const { container } = render(
+      <div onClick={onClick}>
+        <Form>
+          <Form.Item name='name' label='name' help='hello world'>
+            <Input />
+          </Form.Item>
+        </Form>
+      </div>
+    )
+
+    fireEvent.click(container.querySelector('.adm-form-item-label-help')!)
+    expect(onClick).not.toHaveBeenCalled()
+
+    // Click input
+    fireEvent.click(container.querySelector('input')!)
+    expect(onClick).toHaveBeenCalled()
+
+    jest.useRealTimers()
+  })
 })