fix: virtual input value 0 #6231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zombieJ
reviewed
Jul 4, 2023
| @@ -151,7 +151,7 @@ export const VirtualInput = forwardRef<VirtualInputRef, VirtualInputProps>( | |||
| <CloseCircleFill /> | |||
| </div> | |||
| )} | |||
| {!value && ( | |||
| {[undefined, null, ''].includes(value) && ( | |||
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6231 +/- ##
==========================================
- Coverage 90.75% 90.75% -0.01%
==========================================
Files 305 304 -1
Lines 6601 6598 -3
Branches 1644 1645 +1
==========================================
- Hits 5991 5988 -3
Misses 562 562
Partials 48 48
☔ View full report in Codecov by Sentry. |
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6231.surge.sh |
miracles1919
force-pushed
the
fix/virtual-input-value-0
branch
from
85e60a5
to
8de134d
Compare
zombieJ
approved these changes
Jul 10, 2023
miracles1919
added a commit
that referenced
this pull request
Aug 16, 2023
* docs: update doc of SwipeAction ProgressBar ProgressCircle Popover Switch (#6232) * doc: update SwupeAction doc * doc: update ProgressBar ProgressCircle doc * doc: update Popover doc * doc: update Switch doc * test: fix failed test (#6227) * doc: Improve doc descriptions of some components (#6233) * doc: update docs * doc: update doc * fix: virtual input value 0 (#6231) * fix: fix placeholder show when value is number 0 on virtual-input * test: add value `0` --------- Co-authored-by: wuguangsen.wgs <[email protected]> Co-authored-by: miracles1919 <[email protected]> * fix(TextArea): hidden textarea element is not positioned relative to its parent (#6239) fix: hidden textarea element is not positioned relative to its parent * chore: bump 5.32.0 * enhance: useWheel dir change (#6240) * enhance: useWheel dir change * enhance: 代码风格调整 * refactor: 数组解构方式优化 * style: delete note code * chore: prompt when repairing step cloneElement (#6259) * fix(TextArea): reset rows when rows exceed autoSize (#6256) * fix(TextArea): rows should be the smallest of default and autoSize * refactor: adjust rows logic * chore: side add type specification (#6258) * chore: type enhance (#6262) * refactor: to simplify the judge (#6263) * refactor: to simplify the judge * refactor: simplify the judge * fix: add null judge * fix: add judage case * chore: repair type warning (#6267) * fix: classname use repeatedly (#6278) * chore: form's code style optimization (#6279) * refactor(Calendar): change locale from method to string (#6276) * refactor(Calendar): change locale from method to string * test(ConfigProvider): remove spaces in Japanese translation in calendar --------- Co-authored-by: litaoq <[email protected]> * chore: add `--inactive-color-half` type (#6281) * enhance: passive and preventDefault coexist repair (#6284) * enhance: passive and preventDefault coexist repair * refactor: code simplify * test: add useLockScroll test case * chore: pick type to InputHTMLAttributes (#6290) * enhance(toast): compatible with rtl mode (#6287) fix(toast): compatible with rtl mode Co-authored-by: Fog3211 <[email protected]> * test(useLockScroll): update test (#6292) * fix: repir passive and preventDefault in components (#6296) enhance: fix passive and preventDefault in components * chore: eventOptions type fix (#6298) chore: type fix * enhance: floating-panel add classPrefix (#6297) * chore: code simplify (#6295) * chore: code simplify * chore: code simplify * fix: useLockScroll whether the element scroll is in the end #6253 (#6254) * fix: useLockScroll whether the element scroll is in the end #6253 * test: useLockScroll test case #6253 * fix: useLockScroll whether the element scroll is in the end #6253 * test: useLockScroll whether the element scroll is in the end #6253 * test: useLockScroll with strict params #6253 * test: useLockScroll with strict params #6253 * fix: del px and remove {} #6253 * fix: error-block Normal display 0 (#6309) * fix: error-block Normal display 0 * test: add test case * chore: center-popup use classPrefix (#6305) * chore: pickview use classPrefix (#6304) chore: pickview dom use classPrefix * enhance: replace missing colors with css variables. fix #6319 (#6320) * enhance: replace missing colors with css variables. fix #6319 * enhance: replace black color with css variable * chore: update tag snapshots for css var --------- Co-authored-by: Wing <[email protected]> Co-authored-by: WuLiSenSen <[email protected]> Co-authored-by: wuguangsen.wgs <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 二货机器人 <[email protected]> Co-authored-by: whwnow <[email protected]> Co-authored-by: litaoq <[email protected]> Co-authored-by: Hyden Liu <[email protected]> Co-authored-by: Fog3211 <[email protected]> Co-authored-by: Fog3211 <[email protected]> Co-authored-by: wang.haoyu <[email protected]> Co-authored-by: Wuma <[email protected]>
zombieJ
added a commit
that referenced
this pull request
Aug 17, 2023
* docs: update doc of SwipeAction ProgressBar ProgressCircle Popover Switch (#6232) * doc: update SwupeAction doc * doc: update ProgressBar ProgressCircle doc * doc: update Popover doc * doc: update Switch doc * test: fix failed test (#6227) * doc: Improve doc descriptions of some components (#6233) * doc: update docs * doc: update doc * fix: virtual input value 0 (#6231) * fix: fix placeholder show when value is number 0 on virtual-input * test: add value `0` --------- Co-authored-by: wuguangsen.wgs <[email protected]> Co-authored-by: miracles1919 <[email protected]> * fix(TextArea): hidden textarea element is not positioned relative to its parent (#6239) fix: hidden textarea element is not positioned relative to its parent * chore: bump 5.32.0 * enhance: useWheel dir change (#6240) * enhance: useWheel dir change * enhance: 代码风格调整 * refactor: 数组解构方式优化 * style: delete note code * chore: prompt when repairing step cloneElement (#6259) * fix(TextArea): reset rows when rows exceed autoSize (#6256) * fix(TextArea): rows should be the smallest of default and autoSize * refactor: adjust rows logic * chore: side add type specification (#6258) * chore: type enhance (#6262) * refactor: to simplify the judge (#6263) * refactor: to simplify the judge * refactor: simplify the judge * fix: add null judge * fix: add judage case * chore: repair type warning (#6267) * fix: classname use repeatedly (#6278) * chore: form's code style optimization (#6279) * refactor(Calendar): change locale from method to string (#6276) * refactor(Calendar): change locale from method to string * test(ConfigProvider): remove spaces in Japanese translation in calendar --------- Co-authored-by: litaoq <[email protected]> * chore: add `--inactive-color-half` type (#6281) * enhance: passive and preventDefault coexist repair (#6284) * enhance: passive and preventDefault coexist repair * refactor: code simplify * test: add useLockScroll test case * chore: pick type to InputHTMLAttributes (#6290) * enhance(toast): compatible with rtl mode (#6287) fix(toast): compatible with rtl mode Co-authored-by: Fog3211 <[email protected]> * test(useLockScroll): update test (#6292) * fix: repir passive and preventDefault in components (#6296) enhance: fix passive and preventDefault in components * chore: eventOptions type fix (#6298) chore: type fix * enhance: floating-panel add classPrefix (#6297) * chore: code simplify (#6295) * chore: code simplify * chore: code simplify * fix: useLockScroll whether the element scroll is in the end #6253 (#6254) * fix: useLockScroll whether the element scroll is in the end #6253 * test: useLockScroll test case #6253 * fix: useLockScroll whether the element scroll is in the end #6253 * test: useLockScroll whether the element scroll is in the end #6253 * test: useLockScroll with strict params #6253 * test: useLockScroll with strict params #6253 * fix: del px and remove {} #6253 * fix: error-block Normal display 0 (#6309) * fix: error-block Normal display 0 * test: add test case * feat: support for incoming ref to image-uploader #6289 * fix: remove imageUploaderRef openPhoto #6316 * fix: remove log ref:#6316 * doc: update * feat: export image upload ref * doc: update demo --------- Co-authored-by: Wing <[email protected]> Co-authored-by: miracles1919 <[email protected]> Co-authored-by: WuLiSenSen <[email protected]> Co-authored-by: wuguangsen.wgs <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 二货机器人 <[email protected]> Co-authored-by: whwnow <[email protected]> Co-authored-by: litaoq <[email protected]> Co-authored-by: Hyden Liu <[email protected]> Co-authored-by: Fog3211 <[email protected]> Co-authored-by: Fog3211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix placeholder show when value is number 0 on virtual-input