Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: virtual input value 0 #6231

Merged
merged 5 commits into from
Jul 10, 2023
Merged

fix: virtual input value 0 #6231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
276afa5
Merge pull request #1 from ant-design/master
wulisensen Apr 14, 2022
9bcc262
Merge pull request #2 from ant-design/master
wulisensen May 12, 2023
0cbdf4c
Merge pull request #3 from ant-design/master
wulisensen Jul 4, 2023
dd6ab9f
fix: fix placeholder show when value is number 0 on virtual-input
Jul 4, 2023
8de134d
test: add value `0`
miracles1919 Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/virtual-input/tests/virtual-input.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,9 @@ describe('VirtualInput', () => {
).not.toBeVisible()
})
})

test('placeholder should not be shown when value is `0`', () => {
render(<VirtualInput value={0 as any} placeholder='placeholder' />)
expect(screen.queryByText('placeholder')).toBeNull()
})
})
2 changes: 1 addition & 1 deletion src/components/virtual-input/virtual-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export const VirtualInput = forwardRef<VirtualInputRef, VirtualInputProps>(
<CloseCircleFill />
</div>
)}
{!value && (
{[undefined, null, ''].includes(value) && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个测试用例哈~

<div className={`${classPrefix}-placeholder`}>
{props.placeholder}
</div>
Expand Down