Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update calendar #6173

Merged
merged 9 commits into from
Aug 24, 2023
Merged

feat: update calendar #6173

merged 9 commits into from
Aug 24, 2023

Conversation

bravepg
Copy link
Contributor

@bravepg bravepg commented May 22, 2023

新版日期选择器

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

Size Change: +4.71 kB (+1%)

Total Size: 360 kB

Filename Size Change
./lib/bundle/antd-mobile.compatible.umd.js 191 kB +2.4 kB (+1%)
./lib/bundle/antd-mobile.umd.js 150 kB -337 B (0%)
./lib/bundle/style.css 17.4 kB +2.64 kB (+18%) ⚠️
ℹ️ View Unchanged
Filename Size
./lib/bundle/css-vars-patch.css 1.42 kB

compressed-size-action

@github-actions
Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6173.surge.sh

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Patch coverage: 86.62% and project coverage change: -0.18% ⚠️

Comparison is base (69b350a) 91.53% compared to head (ac559c4) 91.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #6173      +/-   ##
===========================================
- Coverage    91.53%   91.36%   -0.18%     
===========================================
  Files          308      310       +2     
  Lines         6630     6668      +38     
  Branches      1637     1657      +20     
===========================================
+ Hits          6069     6092      +23     
- Misses         526      540      +14     
- Partials        35       36       +1     
Files Changed Coverage Δ
src/components/calendar-view/arrow-left-double.tsx 0.00% <ø> (ø)
src/components/calendar-view/arrow-left.tsx 0.00% <ø> (ø)
src/components/calendar-view/convert.ts 100.00% <ø> (ø)
src/components/calendar/index.ts 100.00% <ø> (ø)
src/locales/base.ts 100.00% <ø> (ø)
src/locales/zh-CN.ts 100.00% <ø> (ø)
src/components/calendar/calendar.tsx 66.66% <61.90%> (-18.86%) ⬇️
src/components/calendar-view/calendar-view.tsx 89.79% <89.79%> (ø)
src/components/calendar-view/index.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

| value | The selected date or date range. | `Date \| null` when selection mode is "single". `[Date, Date] \| null` when selection mode is "range" | - |
| weekStartsOn | Week starts on which day. | `'Monday' \| 'Sunday'` | `'Sunday'` |
| renderDate | Custom date rendering. | `(date: Date) => ReactNode` | - | 5.28.0 |
| usePopup | Whether to use popup | `boolean` | `true` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个在其他组件里是 XXXView,感觉也可以照着搞一下。不用 usePopup

@github-actions
Copy link
Contributor

Deploy PR preview failed.

@1587315093
Copy link
Contributor

#5693 那这个pr是不是不需要了

@bravepg bravepg merged commit 9179439 into feature Aug 24, 2023
9 checks passed
@bravepg bravepg deleted the feat/update-calendar branch August 24, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants