Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Radio add click event #6228

Merged
merged 3 commits into from
Jul 4, 2023
Merged

enhance: Radio add click event #6228

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eae10e
enhance: label add stopPropagation
1587315093 Jul 3, 2023
46963a8
enhance: radio add click event
1587315093 Jul 4, 2023
d56bc10
test: add click case
1587315093 Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/radio/index.en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ type RadioValue = string | number
| icon | Customized `icon` icon | `(checked: boolean) => React.ReactNode` | - |
| id | The id of the input element, often used in conjunction with the label | `string` | - |
| onChange | Callback function when checked is changed | `(val: boolean) => void` | - |
| onClick | Radio's click event | `(event: React.MouseEvent<HTMLLabelElement, MouseEvent>) => void` | - |
| value | Value is carrying identification, used in `Group` mode | `RadioValue` | - |

### Radio.Group
Expand Down
1 change: 1 addition & 0 deletions src/components/radio/index.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ type RadioValue = string | number
| icon | 自定义 `icon` 图标 | `(checked: boolean) => React.ReactNode` | - |
| id | `input` 元素的 `id`，常用来配合 `label` 使用 | `string` | - |
| onChange | 变化时回调函数 | `(val: boolean) => void` | - |
| onClick | Radio 的点击事件 | `(event: React.MouseEvent<HTMLLabelElement, MouseEvent>) => void` | - |
| value | 携带的标识值，用于 `Group` 模式 | `RadioValue` | - |

### Radio.Group
Expand Down
2 changes: 2 additions & 0 deletions src/components/radio/radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export type RadioProps = {
id?: string
icon?: (checked: boolean) => React.ReactNode
children?: React.ReactNode
onClick?: (event: React.MouseEvent<HTMLLabelElement, MouseEvent>) => void
} & NativeProps<'--icon-size' | '--font-size' | '--gap'>

const defaultProps = {
Expand Down Expand Up @@ -86,6 +87,7 @@ export const Radio: FC<RadioProps> = p => {
return withNativeProps(
props,
<label
onClick={props.onClick}
1587315093 marked this conversation as resolved.
Show resolved Hide resolved
className={classNames(classPrefix, {
[`${classPrefix}-checked`]: checked,
[`${classPrefix}-disabled`]: disabled,
Expand Down