Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CascaderView support fieldNames #6242

Merged
merged 2 commits into from
Jul 13, 2023
Merged

feat: CascaderView support fieldNames #6242

merged 2 commits into from
Jul 13, 2023

Conversation

1587315093
Copy link
Contributor

@github-actions
Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6242.surge.sh

value: string
disabled?: boolean
children?: CascaderOption[]
[key: string]: any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一般会做成泛型让用户填,默认就还是原样的。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新的 commit 加了默认的 ,看看行不行

@1587315093 1587315093 requested a review from zombieJ July 12, 2023 11:16
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (ae1f895) 91.03% compared to head (3540bc6) 91.05%.

❗ Current head 3540bc6 differs from pull request most recent head e3459b7. Consider uploading reports for the commit e3459b7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #6242      +/-   ##
===========================================
+ Coverage    91.03%   91.05%   +0.01%     
===========================================
  Files          305      307       +2     
  Lines         6583     6596      +13     
  Branches      1643     1648       +5     
===========================================
+ Hits          5993     6006      +13     
  Misses         544      544              
  Partials        46       46              
Impacted Files Coverage Δ
src/components/cascader/cascader.tsx 76.00% <ø> (ø)
src/components/cascader-view/cascader-view.tsx 94.52% <100.00%> (+0.15%) ⬆️
src/hooks/index.tsx 100.00% <100.00%> (ø)
src/hooks/useFieldNames.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 45b7bb6 into ant-design:feature Jul 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants