Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text): add Text component #6349

Closed

Conversation

aso1datov
Copy link
Contributor

@aso1datov aso1datov commented Sep 1, 2023

@aso1datov aso1datov mentioned this pull request Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: +0.01% 🎉

Comparison is base (c4de325) 91.56% compared to head (620434c) 91.57%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6349      +/-   ##
==========================================
+ Coverage   91.56%   91.57%   +0.01%     
==========================================
  Files         306      308       +2     
  Lines        6590     6603      +13     
  Branches     1626     1626              
==========================================
+ Hits         6034     6047      +13     
  Misses        521      521              
  Partials       35       35              
Files Changed Coverage Δ
src/components/check-list/check-list-item.tsx 89.28% <ø> (ø)
src/components/check-list/context.tsx 100.00% <ø> (ø)
src/components/check-list/index.tsx 100.00% <ø> (ø)
src/components/check-list/check-list.tsx 90.47% <50.00%> (ø)
src/components/cascader-view/cascader-view.tsx 94.36% <100.00%> (ø)
src/components/text/index.ts 100.00% <100.00%> (ø)
src/components/text/text.tsx 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6349.surge.sh

@zombieJ
Copy link
Member

zombieJ commented Sep 4, 2023

Feature branch pls. And this PR seems not visible on the preview side bar. Pls check it.

@zombieJ
Copy link
Member

zombieJ commented Sep 4, 2023

In antd, it name as Typography. Pls follow it as Typography component.

@aso1datov
Copy link
Contributor Author

Feature branch pls. And this PR seems not visible on the preview side bar. Pls check it.

I put the component in the experimental section

@zombieJ
Copy link
Member

zombieJ commented Sep 4, 2023

I mean this master which should be feature : )
截屏2023-09-04 15 57 18

@aso1datov aso1datov changed the base branch from master to feature September 6, 2023 07:33
@aso1datov aso1datov changed the base branch from feature to master September 6, 2023 07:34
@zombieJ
Copy link
Member

zombieJ commented Sep 11, 2023

Why change back?

截屏2023-09-11 15 02 54

@aso1datov
Copy link
Contributor Author

Why change back?

截屏2023-09-11 15 02 54

A lot of changes

@zombieJ
Copy link
Member

zombieJ commented Sep 11, 2023

You can picker your commit instead : )

@aso1datov aso1datov closed this Sep 19, 2023
@zombieJ
Copy link
Member

zombieJ commented Sep 22, 2023

Hi, why close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants