Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pick-view add active class #6427

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

1587315093
Copy link
Contributor

@1587315093 1587315093 commented Nov 10, 2023

resolved: #6390

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (9d0edaa) 92.36% compared to head (97fbcdf) 92.08%.
Report is 33 commits behind head on feature.

Files Patch % Lines
...ents/calendar-picker-view/calendar-picker-view.tsx 89.79% 14 Missing and 1 partial ⚠️
src/components/calendar-picker/calendar-picker.tsx 67.64% 9 Missing and 2 partials ⚠️
src/components/image-uploader/image-uploader.tsx 93.44% 7 Missing and 1 partial ⚠️
src/components/dropdown/dropdown.tsx 86.66% 5 Missing and 1 partial ⚠️
src/components/tabs/tabs.tsx 70.00% 6 Missing ⚠️
...ponents/calendar-picker-view/arrow-left-double.tsx 0.00% 3 Missing ⚠️
src/components/calendar-picker-view/arrow-left.tsx 0.00% 3 Missing ⚠️
src/components/popover/popover-menu.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           feature    #6427      +/-   ##
===========================================
- Coverage    92.36%   92.08%   -0.29%     
===========================================
  Files          307      316       +9     
  Lines         6617     6859     +242     
  Branches      1636     1717      +81     
===========================================
+ Hits          6112     6316     +204     
- Misses         470      505      +35     
- Partials        35       38       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6427.surge.sh

@zombieJ
Copy link
Member

zombieJ commented Nov 10, 2023

缺 test case 😼

@1587315093
Copy link
Contributor Author

缺 test case 😼

好的

Copy link
Contributor

Deploy PR preview failed.

@1587315093
Copy link
Contributor Author

缺 test case 😼

done ~

@zombieJ zombieJ merged commit b4489f3 into ant-design:feature Nov 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants