Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add closeOnBack to Popup, CenterPopup and other components built on them #6438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

feat: add `closeOnBack` to Popup, CenterPopup and other components bu…

1cd3e80
Select commit
Loading
Failed to load commit list.
Open

feat: add closeOnBack to Popup, CenterPopup and other components built on them #6438

feat: add `closeOnBack` to Popup, CenterPopup and other components bu…
1cd3e80
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 20, 2023 in 0s

91.94% (target 70.00%)

View this Pull Request on Codecov

91.94% (target 70.00%)

Details

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (671ea15) 92.10% compared to head (1cd3e80) 91.94%.

Files Patch % Lines
src/components/center-popup/center-popup.tsx 33.33% 6 Missing ⚠️
src/components/popup/popup.tsx 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6438      +/-   ##
==========================================
- Coverage   92.10%   91.94%   -0.16%     
==========================================
  Files         316      316              
  Lines        6861     6877      +16     
  Branches     1719     1723       +4     
==========================================
+ Hits         6319     6323       +4     
- Misses        504      516      +12     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.