Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional locale props in ConfigProvider #6451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Nov 23, 2023

Because the locale attribute has default corpus settings, in order to simplify the use of ConfigProvider, the locale attribute can be made optional.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (abef05c) 92.10% compared to head (20f3ff6) 92.26%.
Report is 2 commits behind head on master.

Files Patch % Lines
...onents/cascader-view/use-cascader-value-extend.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6451      +/-   ##
==========================================
+ Coverage   92.10%   92.26%   +0.16%     
==========================================
  Files         316      316              
  Lines        6861     6882      +21     
  Branches     1719     1729      +10     
==========================================
+ Hits         6319     6350      +31     
+ Misses        504      495       -9     
+ Partials       38       37       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6451.surge.sh

@cbbfcd
Copy link
Contributor Author

cbbfcd commented Dec 8, 2023

@zombieJ @1587315093 review pls~

@cbbfcd cbbfcd closed this Dec 11, 2023
@cbbfcd cbbfcd reopened this Dec 11, 2023
@cbbfcd
Copy link
Contributor Author

cbbfcd commented Jun 5, 2024

@zombieJ @1587315093 review pls~

+1 @zombieJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant