Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(infinite-scroll): optimize error handling in scroll functions #6531

Merged
merged 2 commits into from
Feb 5, 2024
Merged

refactor(infinite-scroll): optimize error handling in scroll functions #6531

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
644638a
refactor(infinite-scroll): optimize error handling in scroll functions
chooin Jan 23, 2024
fa263d8
chore: simplify logic
zombieJ Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/infinite-scroll/infinite-scroll.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@
const nextFlag = {}
nextFlagRef.current = nextFlag
await doLoadMore(false)
setFlag(nextFlag)
.then(() => {
setFlag(nextFlag)
})
.catch(() => {})

Check warning on line 79 in src/components/infinite-scroll/infinite-scroll.tsx

View check run for this annotation

Codecov / codecov/patch

src/components/infinite-scroll/infinite-scroll.tsx#L79 

Added line #L79 was not covered by tests
}
},
{
Expand Down Expand Up @@ -104,7 +107,10 @@
async function retry() {
setFailed(false)
await doLoadMore(true)
setFlag(nextFlagRef.current)
.then(() => {
setFlag(nextFlagRef.current)

Check warning on line 111 in src/components/infinite-scroll/infinite-scroll.tsx

View check run for this annotation

Codecov / codecov/patch

src/components/infinite-scroll/infinite-scroll.tsx#L110-L111 

Added lines #L110 - L111 were not covered by tests
})
.catch(() => {})

Check warning on line 113 in src/components/infinite-scroll/infinite-scroll.tsx

View check run for this annotation

Codecov / codecov/patch

src/components/infinite-scroll/infinite-scroll.tsx#L113 

Added line #L113 was not covered by tests
}

return withNativeProps(
Expand Down
Loading