Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): onClick type #6588

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(Button): onClick type #6588

merged 1 commit into from
Apr 8, 2024

Conversation

guoyunhe
Copy link
Contributor

@guoyunhe guoyunhe commented Apr 6, 2024

函数的返回类型用 void | Promise<void> 就够了,再或一个 unknown 是不必要的,在某些 eslint 规则下会报错。

Copy link
Contributor

github-actions bot commented Apr 6, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6588.surge.sh

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (cf550e4) to head (1676535).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6588   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files         318      318           
  Lines        6910     6910           
  Branches     1729     1729           
=======================================
  Hits         6381     6381           
  Misses        493      493           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
./lib/bundle/antd-mobile.es.js 137.36 KB 2.8 s (0%) 1.4 s (+3.37% 🔺) 4.1 s

Copy link
Contributor

github-actions bot commented Apr 6, 2024

Size Change: 0 B

Total Size: 353 kB

ℹ️ View Unchanged
Filename Size
./lib/bundle/antd-mobile.compatible.umd.js 189 kB
./lib/bundle/antd-mobile.umd.js 144 kB
./lib/bundle/css-vars-patch.css 1.43 kB
./lib/bundle/style.css 18 kB

compressed-size-action

@zombieJ zombieJ merged commit 84bad16 into master Apr 8, 2024
10 checks passed
@zombieJ zombieJ deleted the fix-button-type branch April 8, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants