feat(CalendarPickerView): title support boolean value to control whether to hide #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6676.surge.sh |
crazyair
reviewed
Jul 23, 2024
| @@ -41,7 +41,7 @@ export type CalendarPickerViewRef = { | |||
| } | |||
|
|
|||
| export type CalendarPickerViewProps = { | |||
| title?: React.ReactNode | |||
| title?: React.ReactNode | boolean | |||
There was a problem hiding this comment.
true 算什么？这里改成 React.ReactNode | false
crazyair
reviewed
Jul 23, 2024
|
感觉有个问题，以前 title 为假值，可以显示默认的 title，保险起见，可以加 showHeader |
zombieJ
reviewed
Jul 23, 2024
| @@ -117,6 +117,8 @@ export const CalendarPickerView = forwardRef< | |||
| dayjs(dateRange ? dateRange[0] : today).date(1) | |||
| ) | |||
|
|
|||
| const isDisplayHeader = useMemo(() => props.title !== false, [props.title]) | |||
There was a problem hiding this comment.
这个 useMemo 可以不写， !== false 速度比 func call 快多了
|
行，那这个没啥问题 |
zombieJ
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CalendarPickerView 的 title 可以通过配置 false 来隐藏