fix: remove aria-hidden #6688
Merged
fix: remove aria-hidden #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6688.surge.sh |
zombieJ
reviewed
Jul 31, 2024
| @@ -445,7 +445,7 @@ exports[`ImageUploader upload status 1`] = ` | |||
| </span> | |||
| <input | |||
| accept="image/*" | |||
| aria-hidden="true" | |||
| aria-label="adm-image-uploader-input" | |||
There was a problem hiding this comment.
这个 label 不要默认填，可以接受 aria-label 属性来让开发者填。prefix 不是给拼label 用的。而且这也会对多语言用户产生困扰~
Layouwen
force-pushed
the
fix/image-uploader-aria-hidden-error
branch
from
1c43648
to
b0c9a99
Compare
zombieJ
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 ImageUploader 点击的 aria-hidden 报错 #6684