feat(CalendarPickerView): add renderTop and renderBottom hide logic #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6735 +/- ##
=======================================
Coverage 92.68% 92.69%
=======================================
Files 334 334
Lines 7191 7200 +9
Branches 1795 1790 -5
=======================================
+ Hits 6665 6674 +9
+ Misses 517 490 -27
- Partials 9 36 +27 ☔ View full report in Codecov by Sentry. |
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6735.surge.sh |
zombieJ
reviewed
Aug 30, 2024
| @@ -21,8 +21,8 @@ Only the simplest content area is shown here, and other more usages can be consu | |||
| | max | Maximum value of a selectable range. | `Date` | - | | |||
| | min | Minimum value of a selectable range. | `Date` | - | - | | |||
| | onChange | Trigger when selected date changes. | `(val: Date \| null) => void` when selection mode is "single". `(val: [Date, Date] \| null) => void` when selection mode is "range". | - | | |||
| | renderTop | The top information of date render function. | `(date: Date) => ReactNode \| null \| undefined` | - | | |||
| | renderBottom | The bottom information of date render function. | `(date: Date) => ReactNode \| null \| undefined` | - | | |||
| | renderTop | The top information of date render function. | `((date: Date) => ReactNode \| null \| undefined) \| false` | - | | |||
zombieJ
reviewed
Aug 30, 2024
| @@ -44,9 +44,9 @@ export type CalendarPickerViewProps = { | |||
| title?: React.ReactNode | false | |||
| confirmText?: string | |||
| weekStartsOn?: 'Monday' | 'Sunday' | |||
| renderTop?: (date: Date) => React.ReactNode | |||
| renderTop?: ((date: Date) => React.ReactNode) | false | |||
zombieJ
reviewed
Sep 2, 2024
| @@ -243,6 +245,8 @@ export const CalendarPickerView = forwardRef< | |||
| (minDay && d.isBefore(minDay, 'day')) | |||
|
|
|||
| const renderTop = () => { | |||
| if (props.renderTop === false) return | |||
There was a problem hiding this comment.
这个逻辑看起来没有用？下面的代码里已经写了
if (props.renderXXX === false) return
所有 renderXXX 走到的地方其实已经都判断过了
There was a problem hiding this comment.
renderXXX 类型为 function | false
这里如果不把 boolean 过滤掉 ts 会报错, 所以才加上的
There was a problem hiding this comment.
那可以考虑调整一下代码结构，也不需要这个 renderTop 函数了，直接内联写。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加 renderTop 和 renderBottom false 隐藏