Move reference creation out of nodeMap

[jzaffiro]

Tests not passing:

• obliterate.reconnect.spec.ts: "deletes concurrently inserted segment between group ops"

[anthony-murphy]

maybe add an assert that normalizedEndPos is greater than zero

[anthony-murphy]

The test that is failing passed previously, so we should keep it working, as something must be different with this implementation.

[titrindl]

Consider the empty obliteration cases too. What's preventing startPos === 'end'?

[titrindl]

I added the following function on my branch for this purpose:

/**
 * Returns the given place in InteriorSequencePlace form.
 */
export function normalizePlace(place: SequencePlace): InteriorSequencePlace {
	if (typeof place === "number") {
		return { pos: place, side: Side.Before };
	}
	if (place === "start") {
		return { pos: -1, side: Side.After };
	}
	if (place === "end") {
		return { pos: -1, side: Side.Before };
	}
	return place;
}

[titrindl]

With an InteriorSequencePlace you can do the following:

const startPlace = normalizePlace(start);
const startSegment = this.getContainingSegment(startPlace.pos, refSeq, clientId).segment;
obliterate.start = this.createLocalReferencePosition(
	startSegment,
	startPlace.side === Side.Before ? 0 : startSegment?.cachedLength - 1,
	ReferenceType.StayOnRemove | ReferenceType.RangeBegin,
	{ obliterate },
);