Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #196

Merged
merged 6 commits into from
Dec 28, 2024
Merged

Improve README #196

merged 6 commits into from
Dec 28, 2024

Conversation

rmarescu
Copy link
Member

README preview

  • 4 top-level sections:
    • Features
    • Using Shortest in your project
    • Web app development
    • Shortest CLI development
  • Add pnpm shortest:dev to test the CLI without build
  • Simplify instructions for local CLI development

@rmarescu rmarescu self-assigned this Dec 28, 2024
Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shortest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 5:10am

@rmarescu rmarescu marked this pull request as ready for review December 28, 2024 05:23
Copy link
Member Author

@rmarescu rmarescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README preview

  • 4 top-level sections:

    • Features
    • Using Shortest in your project
    • Web app development
    • Shortest CLI development

The content is still quite dense, and this is an attempt to improve readability a bit.

I think the audience can be split in 2:

  • people looking to use Shortest within their project
  • poeple that would like to contribute

With that in mind, I'm thinking of having 3 top-level sections:

  • Features
  • Using Shortest in your project
  • Contributing
    • Web app development
    • Shortest CLI development

As current focus is on the CLI development, I think the order can be swapped.

```bash
npx shortest # for npm
pnpm shortest # for pnpm
yarn shortest # for yarn
```

## Quick Start
### Quick start
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to sentence case for headings for consistency with our other projects.

@@ -194,20 +204,21 @@ vercel link
vercel env pull
```

#### For Other Contributors:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed punctuation from headings.

@rmarescu rmarescu requested a review from slavingia December 28, 2024 05:23
@slavingia slavingia merged commit 4cc1ec7 into main Dec 28, 2024
5 checks passed
@slavingia slavingia deleted the rmarescu/update-readme branch December 28, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants