Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added girth and goal and clean the repo more python syntax #4

Merged
merged 5 commits into from
Sep 12, 2023
Merged

added girth and goal and clean the repo more python syntax #4

merged 5 commits into from
Sep 12, 2023

Conversation

antoinebou12
Copy link
Owner

@antoinebou12 antoinebou12 commented Sep 11, 2023 •
edited
Loading

Description

Added new metrics related to girth and goals for better tracking and analytics. This helps in keeping a more comprehensive record for users.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual testing for different scenarios.

  • Test A: Checked if girth metrics are correctly updated
  • Test B: Checked if goals are saved and retrieved correctly

Test Configuration:

  • Firmware version: 1.0.0
  • Hardware: PC
  • Toolchain: Python 3.8
  • SDK: hass

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@antoinebou12 antoinebou12 marked this pull request as ready for review September 11, 2023 23:50
@antoinebou12 antoinebou12 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 11, 2023
@antoinebou12 antoinebou12 self-assigned this Sep 11, 2023
@antoinebou12 antoinebou12 merged commit 4bdb816 into master Sep 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@antoinebou12 antoinebou12

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antoinebou12