fix(auto): axis without label (#5338)

antvis · Jul 24, 2023 · 06b73c2 · 06b73c2
1 parent 9bd7bd9
commit 06b73c2
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 2 deletions.
diff --git a/__tests__/integration/snapshots/static/alphabetIntervalAutoPaddingLabelHide.png b/__tests__/integration/snapshots/static/alphabetIntervalAutoPaddingLabelHide.png
diff --git a/__tests__/plots/static/alphabet-interval-auto-padding-label-hide.ts b/__tests__/plots/static/alphabet-interval-auto-padding-label-hide.ts
@@ -0,0 +1,27 @@
+import { G2Spec } from '../../../src';
+
+export function alphabetIntervalAutoPaddingLabelHide(): G2Spec {
+  return {
+    type: 'interval',
+    padding: 'auto',
+    transform: [{ type: 'sortX', by: 'y', reverse: true }],
+    data: {
+      type: 'fetch',
+      value: 'data/alphabet.csv',
+    },
+    encode: {
+      x: 'letter',
+      y: 'frequency',
+      color: 'steelblue',
+    },
+    axis: {
+      y: { labelFormatter: '.0%', label: false },
+    },
+    viewStyle: {
+      viewFill: '#4e79a7',
+      plotFill: '#f28e2c',
+      mainFill: '#e15759',
+      contentFill: '#76b7b2',
+    },
+  };
+}
diff --git a/__tests__/plots/static/index.ts b/__tests__/plots/static/index.ts
@@ -274,3 +274,4 @@ export { countriesBubbleLegendSize } from './countries-bubble-legend-size';
 export { cars2PointOrdinalSize } from './cars2-point-ordinal-size';
 export { cars2PointConstantColorSize } from './cars2-point-constant-color-size';
 export { alphabetIntervalTitleAuto } from './alphabet-interval-title-auto';
+export { alphabetIntervalAutoPaddingLabelHide } from './alphabet-interval-auto-padding-label-hide';
diff --git a/src/runtime/component.ts b/src/runtime/component.ts
@@ -691,11 +691,10 @@ function computeAxisSize(
   // Compute Labels.
   const scale = createScale(component, library);
   const labelBBoxes = computeLabelsBBox(rest, scale);
+  const paddingTick = tickLength + labelSpacing;
   if (labelBBoxes) {
     const maxLabelWidth = max(labelBBoxes, (d) => d.width);
     const maxLabelHeight = max(labelBBoxes, (d) => d.height);
-    const paddingTick = tickLength + labelSpacing;
-
     if (isVertical) {
       component.size = maxLabelWidth + paddingTick;
     } else {
@@ -712,6 +711,8 @@ function computeAxisSize(
         component.size = maxLabelHeight + paddingTick;
       }
     }
+  } else {
+    component.size = paddingTick;
   }
 
   // Compute title.