feat: optimize allocations in writable CoW accounts #4846
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature removes the unnecessary calls to Vec::reserve (AccountSharedData.data field) Instead when realloc is detected during deserialization of SVM buffer back into account, extra allocation happens on demand. This should decrease the pressure on allocator when transactions writing to the account do not reallocate, by avoiding allocation where possible.
|
The Firedancer team maintains a line-for-line reimplementation of the |
|
I believe some benchmarks could be run to make the case for this change. Maybe @seanyoung has some suggestions. |
|
Needs a careful review. I'll go over it a few times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unnecessary allocations in CoW accounts'
datafield, during the first write access from within the SVM. Potentially, instruction might just write to an account without reallocating, and thus premature call toVec::reserveintroduces an overhead which could be avoided.Summary of Changes
This performance optimization removes the unnecessary calls to Vec::reserve (on AccountSharedData.data field). Instead when realloc is detected during deserialization of SVM buffer back into account, extra allocation happens on demand. This should decrease the pressure on allocator when instructions writing to the account do not reallocate, by avoiding allocation where possible.