Removes AccountStorageReference #4931
Merged
+35
−107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AccountStorageReference was created to bypass an atomic read when needing the ID of an account storage entry. The ID used to be atomic to allow interior mutability. This was required back when the storages were recycled and their IDs needed to change. Storage recycling has been removed for a few versions now, and the ID also is now non-atomic. Thus the original reason for creating AccountStorageReference no longer applies, and we can remove AccountStorageReference entirely.
Summary of Changes
Replace uses of AccountStorageReference with
Arc<AccountStorageEntry>
and remove AccountStorageReference.