Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1: Disables tar's sparse file handling when archiving a snapshot (backport of #5445) #5505

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 26, 2025

Problem

Upgrading the tar crate causes intermittent snapshot archiving errors123.

For the recent string of snapshot archiving errors, I looked at the tar crate we use in v2.1 vs v2.0.

In v2.1 we use tar version 0.4.42. In v2.0 we use tar version 0.4.41. Looking through the commits between these versions of the tar crate revealed that this lseek error is new in v0.4.42! And here's the PR that added it: alexcrichton/tar-rs#375

I opened an issue on the tar crate: alexcrichton/tar-rs#403.

Summary of Changes

Disable tar's sparse file handing, since the errors only happen when sparse mode is enabled.

Note, I intend to backport this to v2.1.

Additional Testing

I ran this PR on a mnb node for 18+ hours without issue. I know this isn't a long time, as the full snapshot archiving was only exercised a few times, but it does show it is not immediately broken. I also restarted the node and had it load from its own snapshot archives, and that was successful as well. This means the snapshots created were not broken.


This is an automatic backport of pull request #5445 done by Mergify.

Footnotes

  1. https://discord.com/channels/428295358100013066/689412830075551748/1349323763270946826

  2. https://discord.com/channels/428295358100013066/689412830075551748/1352336706581303336

  3. https://github.com/anza-xyz/agave/issues/4211

@mergify mergify bot requested a review from a team as a code owner March 26, 2025 15:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.1%. Comparing base (f07a1e8) to head (7fbb0bb).
Report is 1 commits behind head on v2.1.

Additional details and impacted files
@@            Coverage Diff            @@
##             v2.1    #5505     +/-   ##
=========================================
- Coverage    83.1%    83.1%   -0.1%     
=========================================
  Files         926      926             
  Lines      383808   383817      +9     
=========================================
+ Hits       319195   319197      +2     
- Misses      64613    64620      +7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brooksprumo brooksprumo requested a review from HaoranYi March 26, 2025 18:05
@brooksprumo brooksprumo merged commit 4adcd0f into v2.1 Mar 27, 2025
28 checks passed
@brooksprumo brooksprumo deleted the mergify/bp/v2.1/pr-5445 branch March 27, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants