Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement that full snapshot intervals are a multiple of incremental #5519

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

jstarry
Copy link

@jstarry jstarry commented Mar 26, 2025

Problem

There's no need to restrict snapshot intervals such that full is a multiple of incremental

Summary of Changes

  • Loosen snapshot validation check
  • Update validator warning to reflect loosened constraint

Fixes #

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (46b71e0) to head (40197da).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #5519     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         825      825             
  Lines      372556   372493     -63     
=========================================
- Hits       310479   310394     -85     
- Misses      62077    62099     +22     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarry jstarry requested a review from brooksprumo March 27, 2025 04:24
@jstarry jstarry merged commit 15f3c3e into anza-xyz:master Mar 27, 2025
47 checks passed
@jstarry jstarry deleted the loosen-inc-interval branch March 27, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants