Migrate from solana-feature-set to agave-feature-set #5520
Conversation
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
The Firedancer team maintains a line-for-line reimplementation of the |
jstarry
force-pushed
the
migrate-feature-set
branch
3 times, most recently
from
e304857 to
e534cae
Compare
jstarry
force-pushed
the
migrate-feature-set
branch
2 times, most recently
from
b01a264 to
a97d05d
Compare
|
Ok pretty confident there are no more lingering usages of |
|
After this change we will need to update |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5520 +/- ##
=======================================
Coverage 83.3% 83.3%
=======================================
Files 829 829
Lines 373645 373649 +4
=======================================
+ Hits 311549 311560 +11
+ Misses 62096 62089 -7 🚀 New features to boost your workflow:
|
jstarry
force-pushed
the
migrate-feature-set
branch
from
a97d05d to
00e69a7
Compare
|
@joncinque I rebased to pick up #5525 and also added a change to bump solana-sdk to v2.2.2 which has fixed deprecation annotations to ensure that devs do not unintentionally use modules from sdk when they should be using agave crates. |
* Migrate from solana-feature-set to agave-feature-set * Bump solana-sdk to fix deprecation warnings (cherry picked from commit cb32984) # Conflicts: # Cargo.lock # Cargo.toml # cli/src/program.rs # cli/src/program_v4.rs # cli/tests/program.rs # core/src/banking_stage/latest_unprocessed_votes.rs # core/tests/scheduler_cost_adjustment.rs # genesis/Cargo.toml # genesis/src/main.rs # gossip/Cargo.toml # ledger/src/blockstore_processor.rs # ledger/src/leader_schedule_utils.rs # precompiles/Cargo.toml # precompiles/src/ed25519.rs # precompiles/src/lib.rs # precompiles/src/secp256k1.rs # precompiles/src/secp256r1.rs # program-runtime/Cargo.toml # program-runtime/src/invoke_context.rs # programs/bpf_loader/Cargo.toml # programs/bpf_loader/src/lib.rs # programs/bpf_loader/src/syscalls/cpi.rs # programs/bpf_loader/src/syscalls/mod.rs # programs/sbf/Cargo.lock # programs/sbf/Cargo.toml # programs/sbf/benches/bpf_loader.rs # programs/vote/benches/vote_instructions.rs # runtime/Cargo.toml # runtime/src/bank.rs # runtime/src/bank/check_transactions.rs # runtime/src/bank/tests.rs # runtime/src/verify_precompiles.rs # svm/Cargo.toml # svm/examples/Cargo.lock # svm/examples/paytube/src/processor.rs # svm/src/account_loader.rs # svm/src/transaction_processor.rs # svm/tests/conformance.rs # svm/tests/integration_test.rs # svm/tests/mock_bank.rs
* Migrate from solana-feature-set to agave-feature-set * Bump solana-sdk to fix deprecation warnings
Problem
Codebase still uses the sdk feature set.
Summary of Changes
Fixes #