-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.2: Add agave-precompiles crate (backport of #5509) #5523
Conversation
Cherry-pick of e1162f7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
The Firedancer team maintains a line-for-line reimplementation of the |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
95c9e17
to
483f2ed
Compare
@@ -419,7 +421,7 @@ solana-example-mocks = "=2.2.1" | |||
solana-faucet = { path = "faucet", version = "=2.2.6" } | |||
solana-feature-gate-client = "0.0.2" | |||
solana-feature-gate-interface = "=2.2.1" | |||
solana-feature-set = "=2.2.1" | |||
solana-feature-set = "=2.2.4" # will be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was required to satisfy the dependency resolver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these can be gone before the next 2.2 release, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah they will be removed in #5537
@@ -43,7 +43,7 @@ solana-compute-budget = { path = "../../compute-budget", version = "=2.2.6" } | |||
solana-compute-budget-instruction = { path = "../../compute-budget-instruction", version = "=2.2.6" } | |||
solana-curve25519 = { path = "../../curves/curve25519", version = "=2.2.6" } | |||
solana-decode-error = "=2.2.1" | |||
solana-feature-set = "=2.2.1" | |||
solana-feature-set = "=2.2.4" # will be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was required to satisfy the dependency resolver
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.2 #5523 +/- ##
=========================================
Coverage 83.3% 83.3%
=========================================
Files 801 805 +4
Lines 370379 371531 +1152
=========================================
+ Hits 308650 309802 +1152
Misses 61729 61729 🚀 New features to boost your workflow:
|
@mergify rebase |
✅ Branch has been successfully rebased |
483f2ed
to
4eb3241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport lgtm.
Discussed offline with @jstarry about the concern with SVM dependency on monorepo.
- may be possible to migrate precompiles to normal bpf programs
- use a similar setup to builtins for precompiles; agave adds them to
TransactionProcessor
Problem
Precompile verification is subject to runtime feature gates and should live in the agave monorepo rather than creating a circular dependency between agave and the sdk repos.
Summary of Changes
Everything from sdk that was pulled into agave in this PR will get deprecated in the sdk crates
Fixes #
This is an automatic backport of pull request #5509 done by [Mergify](https://mergify.com).