ARTEMIS-5094 potential null dereference in QueueImpl #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmellr
reviewed
Jan 16, 2025
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
Outdated
Show resolved
Hide resolved
jbertram
force-pushed
the
ARTEMIS-5094
branch
from
a936025 to
b837618
Compare
The `server` variable is used liberally through this `Queue` implementation. It makes sense to assume it is non-null. If it is `null` then a `NullPointerException` will be thrown immediately just as if we used `Objects.requireNonNull(server)`.
jbertram
force-pushed
the
ARTEMIS-5094
branch
from
b837618 to
327ff99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
servervariable is used liberally through thisQueueimplementation. It makes sense to require it to be non-null.