Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARTEMIS-5209] add test and docs for AMQP duplicate Message #5459

Closed
wants to merge 1 commit into from

Conversation

guissalustiano
Copy link

I suggest add duplicate detection id header following the x-opt-delivery-time header,
but after digging around some code I notice this was already implemented, it was just
missing the docs to clarify how to use it.

I suggest add duplicate detection id header following the x-opt-delivery-time header,
but after digging around some code I notice this was already implemented, it was just
missing the docs to clarify how to use it.
@gemmellr
Copy link
Member

As you noticed, the broker already supports duplicate detection with AMQP messages, in the same general way it does for e.g Core and other protocol usages. This was added in some time ago, in ARTEMIS-2294. There are existing tests from that time, though I did just make and improvement to them.

There isnt a specific note on the AMQP page for duplicate detection as it really notes behaviours specific to the AMQP support, whilst for duplicate detection the same general docs on duplicate detection apply to all the protocols and are a better fit. I did reorder and tweak the doc to emphasize the more general details first, before a note of the detail for just the Core Client.

Both the tweaks I made are in 89b3ebb and I updated the Jira to reflect that, so I will close this PR out, but thanks for the contribution!

@gemmellr gemmellr closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants