Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVRO-4051: Remove Superfluous Increments #3143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

AVRO-4051: Remove Superfluous Increments #3143

wants to merge 1 commit into from

Conversation

belugabehr
Copy link
Contributor

What is the purpose of the change

  • Trivial change to remove needless operations - faster ops, smaller package.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

This change added tests and can be verified as follows:

  • Reviewed decompiled version to verify increments were no longer present

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added the Java Pull Requests for Java binding label Sep 2, 2024
@belugabehr belugabehr changed the title AVRO-4051: Remove superfluous increments AVRO-4051: Remove Superfluous Increments Sep 2, 2024
@KalleOlaviNiemitalo
Copy link
Contributor

faster ops

Do benchmark results show such an effect? The code looks like a JIT bytecode-to-machinecode compiler should be able to replace all the uses of i with constants anyway, even if the Java-to-bytecode compiler doesn't do that.

@KalleOlaviNiemitalo
Copy link
Contributor

By i I mean len 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Java Pull Requests for Java binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belugabehr @KalleOlaviNiemitalo