AVRO-4070: Optimize Check Max Collection Length for New Collections #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not objecting, but I'm curious if you have any benchmark numbers showing the effect of this change. |
|
Hello, I'm working through the project using different techniques. This code came to my attention by profiling the following benchmark, not a specific benchmark for this method. Nothing crazy, but this area of the code consumed roughly 1.2% of total cpu time in my personal (read: dated) system. After the change it was roughly 1% of cpu time. So the savings were roughly 0.2% in this array-heavy workload. Thanks. https://softwaremill.com/data-serialization-tools-comparison-avro-vs-protobuf/ |
martin-g
approved these changes
Oct 8, 2024
lang/java/avro/src/main/java/org/apache/avro/SystemLimitException.java
Outdated
Show resolved
Hide resolved
belugabehr
force-pushed
the
belugabehr/AVRO-4070
branch
from
c106905
to
9bc0dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.