Support backup request policy #2734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreateCode
reviewed
Aug 10, 2024
GreateCode
reviewed
Aug 10, 2024
chenBright
force-pushed
the
backup_request_policy
branch
from
e81c8e8
to
c8a88bf
Compare
wwbmmm
reviewed
Aug 19, 2024
|
LGTM |
src/brpc/controller.cpp
Outdated
| @@ -1259,6 +1278,11 @@ int Controller::HandleSocketFailed(bthread_id_t id, void* data, int error_code, | |||
| cntl->timeout_ms(), | |||
| butil::endpoint2str(cntl->remote_side()).c_str()); | |||
| } else if (error_code == EBACKUPREQUEST) { | |||
| BackupRequestPolicy* policy = cntl->_backup_request_policy; | |||
There was a problem hiding this comment.
我看RetryPolicy和backup重试都是在OnVersionedRPCReturned这个函数里面，没理解为啥这个policy要在这里。
There was a problem hiding this comment.
当时想着就不需要SetFailed和起协程了。但是现在发现BackupRequestPolicy同样有#2419 的问题，所以还是得改成在OnVersionedRPCReturned里面。
There was a problem hiding this comment.
@yanglimingcn 再看看
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve #2668 , resolve #2695
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: