Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timedlock of fast/hook pthread and bthread::Mutex #2760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support timedlock of fast/hook pthread and bthread::Mutex #2760

wants to merge 1 commit into from
+212 −37

Conversation

chenBright
Copy link
Contributor

@chenBright chenBright commented Sep 9, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number:

Problem Summary:

  1. linux上未支持pthread_mutex_timedlock contention profile；
  2. FastPthreadMutex未支持timedlock以及对应的contention profile；
  3. 使用pthread_mutex_timedlock后，Support pthread mutex deadlock detection #2692 会误判。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright chenBright force-pushed the timedlock branch 2 times, most recently from f880c80 to ad75348 Compare September 12, 2024 02:43
@chenBright chenBright changed the title Support fast/hook pthread timedlock Support timedlock of fast/hook pthread and bthread::Mutex Sep 12, 2024
@wwbmmm
Copy link
Contributor

wwbmmm commented Sep 20, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenBright @wwbmmm