[ISSUE-4305] Optimize the usage of static method (#4309)

static method shouldn't be called by object, it should be call by class
apache · Apr 24, 2023 · 2439589 · 2439589
1 parent b941983
commit 2439589
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/.DS_Store b/.DS_Store
diff --git a/sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java b/sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
@@ -325,12 +325,12 @@ private CarbonFileInputFormat prepareFileInputFormat(Job job, boolean enableBloc
       table.getTableInfo().getFactTable().setTableProperties(tableProperties);
     }
     final CarbonFileInputFormat format = new CarbonFileInputFormat();
-    format.setTableInfo(job.getConfiguration(), table.getTableInfo());
-    format.setTablePath(job.getConfiguration(), table.getTablePath());
-    format.setTableName(job.getConfiguration(), table.getTableName());
-    format.setDatabaseName(job.getConfiguration(), table.getDatabaseName());
+    CarbonFileInputFormat.setTableInfo(job.getConfiguration(), table.getTableInfo());
+    CarbonFileInputFormat.setTablePath(job.getConfiguration(), table.getTablePath());
+    CarbonFileInputFormat.setTableName(job.getConfiguration(), table.getTableName());
+    CarbonFileInputFormat.setDatabaseName(job.getConfiguration(), table.getDatabaseName());
     if (filterExpression != null) {
-      format.setFilterPredicates(job.getConfiguration(),
+      CarbonFileInputFormat.setFilterPredicates(job.getConfiguration(),
           new IndexFilter(table, filterExpression, true));
     }
     if (null != this.fileLists) {
@@ -345,7 +345,7 @@ private CarbonFileInputFormat prepareFileInputFormat(Job job, boolean enableBloc
               "Complex child columns projection NOT supported through CarbonReader");
         }
       }
-      format.setColumnProjection(job.getConfiguration(), projectionColumns);
+      CarbonFileInputFormat.setColumnProjection(job.getConfiguration(), projectionColumns);
     }
     if ((disableLoadBlockIndex) && (filterExpression == null)) {
       job.getConfiguration().set("filter_blocks", "false");