Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

vm: backend migration changes support #789

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

vm: backend migration changes support #789

wants to merge 12 commits into from

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Oct 6, 2020 •
edited
Loading

Backend changes at apache/cloudstack#4385

Use migrateVirtualMachineWithVolume for stopped VM migration to a different storage pool
VR and system VM migration between cluster changes

Screenshots:
Screenshot from 2020-11-13 11-36-59

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@shwstppr
add missing file
5910756 
Signed-off-by: Abhishek Kumar <[email protected]>
@rohityadavcloud rohityadavcloud added this to the 1.1 milestone Oct 6, 2020
@borisstoyanov
Copy link

@blueorangutan package

@blueorangutan
Copy link

@borisstoyanov a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3641)

@shwstppr
show storage migration required
92dd3c7 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
show cluster, pod name
48e02d9 
Signed-off-by: Abhishek Kumar <[email protected]>
rohityadavcloud
rohityadavcloud approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs manual testing against backend PR

@shwstppr
fix vm storage migration
53603ac 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
fix
a4b457f 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
wip changes
9ae20c5 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
fix
a9099bc 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Merge branch 'master' into vm-migrate-backend-improvements
186d36b 
Signed-off-by: Abhishek Kumar <[email protected]>
This was referenced Nov 20, 2020
Merged
Merged
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3682)

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3731)

@shwstppr shwstppr mentioned this pull request Dec 29, 2020
Closed
@shwstppr shwstppr marked this pull request as ready for review January 18, 2021 07:36
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3814)

@rohityadavcloud
Copy link
Member

@shwstppr can you add the link to the backend PR on PR description

@shwstppr
Copy link
Contributor Author

shwstppr commented Jan 18, 2021 •
edited
Loading

@rhtyd it was there in the end. Moved it to top

sureshanaparti
sureshanaparti reviewed Jan 19, 2021
View reviewed changes
src/locales/en.json Outdated
@@ -2030,6 +2033,7 @@
"label.storage.tags": "Storage Tags",
"label.storage.traffic": "Storage Traffic",
"label.storageid": "Primary Storage",
"label.storagemigrationrequired": "Storage Migration Required",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"label.storage.migration.required" key might look better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@davidjumani davidjumani Awaiting requested review from davidjumani

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@shwstppr @blueorangutan @borisstoyanov @rohityadavcloud @sureshanaparti