-
Notifications
You must be signed in to change notification settings - Fork 38
Dont pass account/domainid for upload sslcert in project view #893
base: master
Are you sure you want to change the base?
Conversation
In project view, we can upload ssl certificate either by using projectid or accountid/domainid combination. Since we are passing all 3 parameters, we cant upload sslcert in project view
@blueorangutan package |
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
Packaging result: ✔️centos ✔️debian ✔️archive. |
@ravening This will make the form require the user to enter the account as well as domain which is redundant as he's already navigated to the desired account. Instead, would it be better to exclude passing the projectid if the current route contains "account" over at https://github.com/apache/cloudstack-primate/blob/master/src/utils/request.js#L83 ? |
@davidjumani we don't need to enter anything here. If we are in project view then project id is passed else account/domain will be taken from backend code If we pass both account and domain in project view then exception is thrown |
@ravening The account will be taken for the current user but say an admin will have to pass the account and domain while adding a certificate for another account, after having navigated to that account |
Ping @ravening any update on this? |
@ravening @rhtyd @davidjumani |
In project view, we can upload ssl certificate either by using
projectid or accountid/domainid combination. Since we are passing
all 3 parameters, we cant upload sslcert in project view