Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

CB-13294 Remove cordova-plugin-compat #156

Closed
wants to merge 1 commit into from

Conversation

kelvindart
Copy link

Platforms affected

[email protected]

What does this PR do?

Removes the dependency on cordova-plugin-compat, and includes checks for min platform version.

What testing has been done on this change?

Testing 1:

  • Add local plugin to project containing [email protected]
  • Verify plugin installs, and app runs.

Testing 2:

  • Add local plugin to project containing [email protected]
  • Verify plugin does not install.
  • Console log as follows:
Plugin doesn't support this project's cordova-android version. cordova-android: 6.2.3, failed version requirement: >=6.3.0
Skipping 'cordova-plugin-contacts' for android

This is desirable - this change stops the plugin being installed on <[email protected]

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Copy link
Contributor

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in e47d53b Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants