Support Dictionary and List types in scalar_to_sql
#14346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @cetra3 -- I think this PR needs to be merged up from main -- the PR currently has a fialure due to a logical conflict |
alamb
changed the title
scalar_to_sqlDictionary types in scalar_to_sql
alamb
changed the title
Dictionary types in scalar_to_sqlDictionary and List types in scalar_to_sql
alamb
approved these changes
Feb 3, 2025
| "'foo'", | ||
| ), | ||
| ( | ||
| Expr::Literal(ScalarValue::List(Arc::new( |
There was a problem hiding this comment.
Can you please also add a test for LargeList?
cetra3
force-pushed
the
expr_adjustments
branch
from
a8a934a to
a1caa5d
Compare
|
🚀 |
|
Thanks again @cetra3 and @phillipleblanc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Adds more support for
ScalarValuevariants inscalar_to_sqlWhat changes are included in this PR?
Includes support for lists and dictionary type scalars.
Are these changes tested?
Tests have been added for the
ScalarValue::DictionaryandScalarValue::ListvariantsAre there any user-facing changes?
There are no breaking/user-facing changes